Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write more unit tests for the find controller #10425

Merged
merged 1 commit into from
Jan 12, 2019
Merged

Write more unit tests for the find controller #10425

merged 1 commit into from
Jan 12, 2019

Conversation

timvandermeij
Copy link
Contributor

Fixes #7356.

@timvandermeij
Copy link
Contributor Author

/botio unittest

@mozilla mozilla deleted a comment from pdfjsbot Jan 6, 2019
@mozilla mozilla deleted a comment from pdfjsbot Jan 6, 2019
@mozilla mozilla deleted a comment from pdfjsbot Jan 6, 2019
@mozilla mozilla deleted a comment from pdfjsbot Jan 6, 2019
@timvandermeij
Copy link
Contributor Author

/botio unittest

@mozilla mozilla deleted a comment from pdfjsbot Jan 6, 2019
@mozilla mozilla deleted a comment from pdfjsbot Jan 6, 2019
@mozilla mozilla deleted a comment from pdfjsbot Jan 6, 2019
@mozilla mozilla deleted a comment from pdfjsbot Jan 6, 2019
@timvandermeij
Copy link
Contributor Author

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Jan 6, 2019

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1e1dbeaf668bf11/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 6, 2019

From: Bot.io (Windows)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/b7673f6dac56020/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 6, 2019

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/1e1dbeaf668bf11/output.txt

Total script time: 2.53 mins

  • Unit Tests: FAILED

@pdfjsbot
Copy link

pdfjsbot commented Jan 6, 2019

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/b7673f6dac56020/output.txt

Total script time: 4.74 mins

  • Unit Tests: Passed

@timvandermeij
Copy link
Contributor Author

/botio-linux unittest

@pdfjsbot
Copy link

pdfjsbot commented Jan 6, 2019

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/83c1e8e901fa820/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 6, 2019

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/83c1e8e901fa820/output.txt

Total script time: 2.51 mins

  • Unit Tests: Passed

Snuffleupagus
Snuffleupagus approved these changes Jan 7, 2019
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, modulo a couple of small comments/questions.
Thank you for doing this :-)

test/unit/pdf_find_controller_spec.js Outdated Show resolved Hide resolved
test/unit/pdf_find_controller_spec.js Outdated Show resolved Hide resolved
test/unit/pdf_find_controller_spec.js Show resolved Hide resolved
@timvandermeij timvandermeij merged commit a37ea16 into mozilla:master Jan 12, 2019
@timvandermeij timvandermeij deleted the find-controller-unit-tests branch January 12, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timvandermeij @pdfjsbot @Snuffleupagus