Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid truncating inline images, where the data and the "EI" marker is glued together (issue 10388) #10436

Merged
merged 2 commits into from
Jan 12, 2019

Conversation

Snuffleupagus
Copy link
Collaborator

Thanks to the excellent debugging done by @janpe2, this was easy to fix!

Fixes #10388.

… glued together (issue 10388)

Thanks to the *excellent* debugging done by @janpe2, this was easy to fix!
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jan 9, 2019

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/02b8f9fc1177014/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 9, 2019

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/a2ce5ff08535d32/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 9, 2019

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/02b8f9fc1177014/output.txt

Total script time: 17.80 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jan 9, 2019

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/a2ce5ff08535d32/output.txt

Total script time: 23.49 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/16cf4411ffc63dc/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/16cf4411ffc63dc/output.txt

Total script time: 1.67 mins

Published

@timvandermeij timvandermeij merged commit b531fc4 into mozilla:master Jan 12, 2019
@timvandermeij
Copy link
Contributor

Thank you for fixing this!

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/7b5c7aa95c00372/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 1

Live output at: http://54.215.176.217:8877/8e3bf5ff9822486/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/7b5c7aa95c00372/output.txt

Total script time: 16.14 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/8e3bf5ff9822486/output.txt

Total script time: 21.49 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-10388 branch January 12, 2019 21:19
lpillonel pushed a commit to lpillonel/pdf.js that referenced this pull request Jan 18, 2019
… glued together (issue 10388) (mozilla#10436)

Thanks to the *excellent* debugging done by @janpe2, this was easy to fix!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADP paystubs still render slightly incorrectly (underscores below commas and dots)
3 participants