Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop bundling the ReadableStream polyfill in MOZCENTRAL builds (PR 10470 follow-up) #10484

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

Snuffleupagus
Copy link
Collaborator

Based on the discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1521413, this patch simply removes the ReadableStream polyfill completely from MOZCENTRAL builds.

With this patch, the size of the gulp mozcentral build target is thus further reduced (building on PR #10470):

build/mozcentral
master 3 339 666
patch 3 209 572

/cc @brendandahl
/cc @rvandermeulen
/cc @timvandermeij

…10470 follow-up)

Based on the discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1521413, this patch simply removes the `ReadableStream` polyfill completely from MOZCENTRAL builds.

With this patch, the size of the `gulp mozcentral` build target is thus further reduced (building on PR 10470):

|       | `build/mozcentral`
|-------|-------------------
|master |   3 339 666
|patch  |   3 209 572
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/212456f2284fff9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/212456f2284fff9/output.txt

Total script time: 1.64 mins

Published

@timvandermeij
Copy link
Contributor

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/ec8346acd1bb911/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/0f7c3b122c7869d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/ec8346acd1bb911/output.txt

Total script time: 2.58 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/0f7c3b122c7869d/output.txt

Total script time: 5.17 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit 9128335 into mozilla:master Jan 23, 2019
@timvandermeij
Copy link
Contributor

Looks good to me. Thanks!

@Snuffleupagus Snuffleupagus deleted the rm-mozcentral-streams branch January 24, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants