Put the string name of the glyph in the charset array. #10604
Conversation
|
@Snuffleupagus Can you review? |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2e6bf79814870c4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/d65b00a29621abd/output.txt |
There was a problem hiding this comment.
Would it make sense to revert
Line 956 in 34022d2
this.strings.push(value) again, since nothing seems to be using that any more?
Thanks for the quick fix, looks good to me!
src/core/fonts.js
Outdated
| @@ -3335,14 +3335,14 @@ var Type1Font = (function Type1FontClosure() { | |||
| cff.globalSubrIndex = new CFFIndex(); | |||
|
|
|||
| var count = glyphs.length; | |||
| var charsetArray = [0]; | |||
| var charsetArray = ['.notdef']; | |||
| var i, ii; | |||
| for (i = 0; i < count; i++) { | |||
| var index = CFFStandardStrings.indexOf(charstrings[i].glyphName); | |||
There was a problem hiding this comment.
Nit: Would it make (any) sense to define let glyphName = charstrings[i].glyphName; once at the top of the loop, rather than re-getting it potentially three times per iteration?
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2e6bf79814870c4/output.txt Total script time: 17.97 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/d65b00a29621abd/output.txt Total script time: 25.53 mins
|
Also, only warn once per font when missing a glyph name.
brendandahl
force-pushed
the
fix-type1-charset
branch
from
ab23487
to
7d6ab08
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/1d7929abe67ba3b/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f4edbdd0724b73f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f4edbdd0724b73f/output.txt Total script time: 18.04 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/1d7929abe67ba3b/output.txt Total script time: 25.46 mins
|
Summary: Includes pdf.js pull requests: mozilla/pdf.js#10591 mozilla/pdf.js#10604 Reviewers: yury Reviewed By: yury Bug #: 1530881 Differential Revision: https://phabricator.services.mozilla.com/D22131 --HG-- extra : rebase_source : a325a575ce4511bfa37c899411ece4fac17d6900 extra : histedit_source : d3026260dd6701c4def4c0e74ad84516c138b292
Summary: Includes pdf.js pull requests: mozilla/pdf.js#10591 mozilla/pdf.js#10604 Reviewers: yury Reviewed By: yury Bug #: 1530881 Differential Revision: https://phabricator.services.mozilla.com/D22131
Also, only warn once per font when missing a glyph name.