Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type validation to the default_preferences generation (PR 10548 follow-up) #10610

Merged
merged 1 commit into from
Mar 6, 2019

Commits on Mar 3, 2019

  1. Add type validation to the default_preferences generation (PR 10548…

    … follow-up)
    
    The generated `default_preferences.json` file is necessary when initializing the Firefox preferences, which only supports certain types, hence this patch adds additional validation to help prevent run-time errors in Firefox.
    
    Given that these changes add a code-path to `AppOptions.getAll` which could throw, the `OptionKind.PREFERENCE` branch is also modified to require *exact* matching to prevent (future) errors in the viewer.
    
    Finally the conditionally defined `defaultOptions` will no longer (potentially) be considered during the `gulp default_preferences` task, to make it more difficult for them to be accidentally included.
    Snuffleupagus committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    f7cc331 View commit details
    Browse the repository at this point in the history