Avoid dispatching range requests to fetch PDF data that's already loaded with streaming (PR 10675 follow-up) #10694
Conversation
Snuffleupagus
force-pushed
the
main-thread-progressiveDataLength
branch
from
1ae1d34
to
a986ea6
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/dcefecc4684b5af/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/8b3bf300428b7e3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/dcefecc4684b5af/output.txt Total script time: 18.18 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/8b3bf300428b7e3/output.txt Total script time: 25.52 mins
Image differences available at: http://54.215.176.217:8877/8b3bf300428b7e3/reftest-analyzer.html#web=eq.log |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/bcb347e2388ddcc/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/bcb347e2388ddcc/output.txt Total script time: 25.49 mins
|
Snuffleupagus
force-pushed
the
main-thread-progressiveDataLength
branch
from
a986ea6
to
027195e
Compare
|
This is currently blocked on a definitive answer to the discussion starting at #10696 (comment), since if the current code is wrong (which I really don't hope) then this PR would likely require adjustments as well. |
|
@yurydelendik Ping; any chance that you have time to review this, and provide an answer to #10694 (comment) as well? |
…ded with streaming (PR 10675 follow-up) *Please note:* This patch purposely ignores `src/display/network.js`, since its support for progressive reading depends on the non-standard `moz-chunked-arraybuffer` responseType which is currently in the process of being removed.
Snuffleupagus
force-pushed
the
main-thread-progressiveDataLength
branch
from
027195e
to
a7273c8
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/13e3a12445c0670/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/2afe0edc2d41c1f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/13e3a12445c0670/output.txt Total script time: 17.79 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/2afe0edc2d41c1f/output.txt Total script time: 25.24 mins
Image differences available at: http://54.215.176.217:8877/2afe0edc2d41c1f/reftest-analyzer.html#web=eq.log |
|
Nice work! |
Please note: This patch purposely ignores
src/display/network.js, since its support for progressive reading depends on the non-standardmoz-chunked-arraybufferresponseType which is now in the process of being removed./cc @yurydelendik
Edit: Note that PR #10675 must land first, since otherwise you'd risk breaking the PDF Viewer in Firefox.