[Firefox] Ensure that loading progress is reported, and the loadingBar updated, when disableRange=true is set
#10714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
firefox-transport-stream-progress
branch
from
e73634f
to
b24723d
Compare
…r updated, when `disableRange=true` is set With PR 10675 having fixed the completely broken `disableRange=true` setting in the Firefox version of PDF.js, I couldn't help but noticing that loading progress is never reported properly in that case. Currently loading progress is only reported for the `rangeProgress` chrome-event, which obviously isn't dispatched with `disableRange=true` set. However, the `progressiveRead` chrome-event includes loading progress as well, but this information isn't being used in any way. Furthermore, the `PDFDataRangeTransport.onDataProgress` method wasn't able to handle "complete" loading information, and neither was `PDFDataTransportStream._onProgress` since that method would only ever attempt to report it through a RangeReader (which won't exist when `disableRange=true` is set).
Snuffleupagus
force-pushed
the
firefox-transport-stream-progress
branch
from
b24723d
to
f0a28b3
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f90838320854bf6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6b1f6b4b3e01c16/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f90838320854bf6/output.txt Total script time: 2.80 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6b1f6b4b3e01c16/output.txt Total script time: 6.07 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ad82f4dd3e28e88/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ad82f4dd3e28e88/output.txt Total script time: 1.88 mins Published |
timvandermeij
approved these changes
Apr 6, 2019
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PR #10675 having fixed the completely broken
disableRange=truesetting in the Firefox version of PDF.js, I couldn't help but noticing that loading progress is never reported properly in that case.Currently loading progress is only reported for the
rangeProgresschrome-event, which obviously isn't dispatched withdisableRange=trueset. However, theprogressiveReadchrome-event includes loading progress as well, but this information isn't being used in any way.Furthermore, the
PDFDataRangeTransport.onDataProgressmethod wasn't able to handle "complete" loading information, and neither wasPDFDataTransportStream._onProgresssince that method would only ever attempt to report it through a RangeReader (which won't exist whendisableRange=trueis set).