Fix glyph at index zero in CIDFontType2 that has a CIDToGIDMap stream

[janpe2]

Fixes #10519

See the description of the problem in #10519 (comment)

@Snuffleupagus Thank you for the idea (#10519 (comment)) to use ToUnicode in deciding when glyph index zero is necessary or not.

I also found out that when the glyph index zero is duplicated, we must set its left sidebearing (LSB) in the hmtx table. Currently just zeros are appended as LSB values, which makes the glyph positioned too far to the left. Because of this change in core/fonts.js some characters move also in regression test "issue3427". Now the glyphs are actually in correct positions. (See 'C' in the bold font and 'P' in the regular font in "issue3427".)

[Snuffleupagus]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/55bd504b0115565/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/623e0ac426ccd01/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.67.70.0:8877/55bd504b0115565/output.txt

Total script time: 17.74 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/55bd504b0115565/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.215.176.217:8877/623e0ac426ccd01/output.txt

Total script time: 25.68 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/623e0ac426ccd01/reftest-analyzer.html#web=eq.log

[timvandermeij]

/botio makeref

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/5413f1343d4ce07/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/cc3648bb4778c87/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.67.70.0:8877/cc3648bb4778c87/output.txt

Total script time: 16.29 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://54.215.176.217:8877/5413f1343d4ce07/output.txt

Total script time: 23.19 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[timvandermeij]

Thank you!