Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply bounding box before using shading patterns. #10851

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

brendandahl
Copy link
Contributor

Fixes #8092

@brendandahl
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/054deb3829880f7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/8d2d9c5924c4d7f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/054deb3829880f7/output.txt

Total script time: 17.81 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/054deb3829880f7/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/8d2d9c5924c4d7f/output.txt

Total script time: 25.63 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/8d2d9c5924c4d7f/reftest-analyzer.html#web=eq.log

src/core/pattern.js Outdated Show resolved Hide resolved
@timvandermeij
Copy link
Contributor

I think this is good to merge once the two comments above are resolved.

@brendandahl
Copy link
Contributor Author

Sorry for the delay on this and the other patch. I ended up finding quite a few problems with how we're doing patterns with respect to transforms and the patch is turning into much more work. I'll hopefully have some more time this week to give it another stab.

@brendandahl
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2019

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/ed98e32222ed257/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2019

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/9e77dbaf32b160c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2019

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/ed98e32222ed257/output.txt

Total script time: 17.56 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/ed98e32222ed257/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2019

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/9e77dbaf32b160c/output.txt

Total script time: 26.36 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/9e77dbaf32b160c/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8c11d3fe7e44bc5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/8c11d3fe7e44bc5/output.txt

Total script time: 1.77 mins

Published

@timvandermeij timvandermeij merged commit ed3954f into mozilla:master Jul 12, 2019
@timvandermeij
Copy link
Contributor

Looks good; thank you!

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/60c6a9ad2316e85/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 2

Live output at: http://54.215.176.217:8877/2225c0078566b10/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/60c6a9ad2316e85/output.txt

Total script time: 15.96 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/2225c0078566b10/output.txt

Total script time: 23.33 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shading pattern bbox ignored
4 participants