Implement tiling patterns for the SVG back-end #10902
Conversation
There was a problem hiding this comment.
I haven't tested this yet, but I really like that the implementation is short and easy to follow!
It may not be perfect, [...]
That's perfectly okay, in fact, it's much easier to review/merge if the patch is small. It's always preferred to have multiple smaller iterations than one big patch.
|
/botio-linux preview |
timvandermeij
changed the title
There was a problem hiding this comment.
I think this is good to merge when the final comment is addressed. I have updated the title and the description of the pull request with additional details and which issues are fixed/improved by this patch.
After you've made the final changes, please squash the commits into one commit. You can check https://github.com/mozilla/pdf.js/wiki/Squashing-Commits for how to do that easily. Thank you!
|
@timvandermeij @janpe2 Please review it. |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8a56dc878364310/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8a56dc878364310/output.txt Total script time: 1.90 mins Published |
|
Nice work; thank you for improving the SVG back-end! |
It may not be perfect, but some PDFs, such as #10796, can be rendered.
Fixes #10796.
Improves #4985.