-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move PDFWorkerStream
and related code to its own file
#10903
Conversation
Since all other `IPDFStream` implementations live in their own files, it seems reasonable for these to do so as well. Furthermore, converts all of the relevant code to ES6 classes and updates the interface definitions to mark a couple of methods `async`.
975d9ba
to
021e5ff
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/609467f6ec0a38d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/2efa8ef20c7bc0d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/609467f6ec0a38d/output.txt Total script time: 17.74 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/2efa8ef20c7bc0d/output.txt Total script time: 25.32 mins
Image differences available at: http://54.215.176.217:8877/2efa8ef20c7bc0d/reftest-analyzer.html#web=eq.log |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e715370fd71ddd6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/cc8929ff537212d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e715370fd71ddd6/output.txt Total script time: 1.88 mins Published |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/cc8929ff537212d/output.txt Total script time: 2.54 mins
|
Looks good! |
Since all other
IPDFStream
implementations live in their own files, it seems reasonable for these to do so as well.Furthermore, converts all of the relevant code to ES6 classes and updates the interface definitions to mark a couple of methods
async
.