Simplify, and inline, the finalize
function in the MessageHandler
class
#10970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
finalize
helper function has only a single call-site, and furthermore it's just a one-liner too. Furthermore it's only ever called with aPromise
as its argument, meaning that it's unnecessarily convoluted as well (i.e. thePromise.resolve()
part shouldn't be necessary).Hence this code can be both simplified and inlined at its only call-site instead.