Refactor the onBeforeDraw/onAfterDraw functionality used in BaseViewer and PDFPageView
#10990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Viewer` and `PDFPageView` This functionality is very old, and pre-dates e.g. the introduction of the `EventBus` by a number of years. Rather than attaching two callback functions to every single `PDFPageView` instance, it's thus now possible to utilize the `EventBus` such that you only need a grand total of two listeners to achieve the same result. For the `onAfterDraw` callback the replacement is particularly simple, given that a 'pagerendered' event is already being dispatched in the appropriate spot. An added benefit here is the ability to remove the event listener, since we only ever care about *one* (arbitrary) page being rendered for the `BaseViewer.onePageRendered` promise. For the `onBeforeDraw` callback, a new 'pagerender' event was thus added to replace the callback.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3a8cd3e7f87d67c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/3a8cd3e7f87d67c/output.txt Total script time: 1.73 mins Published |
timvandermeij
approved these changes
Jul 19, 2019
|
Looks good! I really like the decoupling of components using the event bus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is very old, and pre-dates e.g. the introduction of the
EventBusby a number of years. Rather than attaching two callback functions to every singlePDFPageViewinstance, it's thus now possible to utilize theEventBussuch that you only need a grand total of two listeners to achieve the same result.For the
onAfterDrawcallback the replacement is particularly simple, given that a 'pagerendered' event is already being dispatched in the appropriate spot. An added benefit here is the ability to remove the event listener, since we only ever care about one (arbitrary) page being rendered for theBaseViewer.onePageRenderedpromise.For the
onBeforeDrawcallback, a new 'pagerender' event was thus added to replace the callback.