-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a work-around, in glyphlist.js
, for bad PDF generators which use a non-standard /f_f
string in the Encoding
dictionary when referring to the ff ligature (issue 11016)
#11020
Conversation
…e a non-standard `/f_f` string in the `Encoding` dictionary when referring to the ff ligature (issue 11016) This patch will not incur any (measurable) overhead, since the glyphlist is already quite long and one more entry won't really matter, which is important given that this sort of PDF corruption ought to be very rare. Furthermore, this patch purposely does *not* add a bunch of similarly modified ligature names on pure speculation. Any similar additions, for other ligatures, should only be made if there's real-world examples of PDF files where that's actually necessary.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/1340e1b2e1b6277/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7a2bbe651afca56/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7a2bbe651afca56/output.txt Total script time: 17.45 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/1340e1b2e1b6277/output.txt Total script time: 25.64 mins
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0425f95d31f7fcf/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/0425f95d31f7fcf/output.txt Total script time: 1.71 mins Published |
Thanks! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f2cf2f931c7ed02/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/3bc2de9a660f3d5/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f2cf2f931c7ed02/output.txt Total script time: 15.93 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/3bc2de9a660f3d5/output.txt Total script time: 23.05 mins
|
This patch will not incur any (measurable) overhead, since the glyphlist is already quite long and one more entry won't really matter, which is important given that this sort of PDF corruption ought to be very rare.
Furthermore, this patch purposely does not add a bunch of similarly modified ligature names on pure speculation. Any similar additions, for other ligatures, should only be made if there's real-world examples of PDF files where it's actually necessary.
Fixes #11016.