Use more ES6 syntax in the annotation code #11108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`let` is converted to `const` where possible, `var` usage is disabled and template strings are used where possible.
|
/botio test |
Snuffleupagus
approved these changes
Aug 31, 2019
`let` is converted to `const` where possible.
timvandermeij
force-pushed
the
es6-annotations
branch
from
168f1c9
to
2866c8a
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/cb4a1fd4ccdc424/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6cfa02c1e5941e7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/cb4a1fd4ccdc424/output.txt Total script time: 17.64 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6cfa02c1e5941e7/output.txt Total script time: 25.85 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that there are some open issues regarding annotations, I think it's a good idea to, before we start working on them, make sure that the annotation code is cleaned up and completely uses ES6 syntax. This commit series does that.