Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the eslint-plugin-mozilla to the latest version (PR 10905 follow-up) #11127

Merged
merged 1 commit into from
Sep 7, 2019

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Sep 7, 2019

This required adding a number of additional dependencies, based on https://dxr.mozilla.org/mozilla-central/rev/4aed8e10318f38571712350856bf9e61c5f84e1f/tools/lint/eslint/eslint-plugin-mozilla/package.json#32-37

Since this, implicitly, enabled "prettier"[1] for the extensions/firefox directory a couple of small code changes were necessary as well.


[1] Generally speaking I'm wondering if that name is deliberately ironic, since the style it enforces is often times extremely weird and ugly :-P

…llow-up)

This required adding a number of additional dependencies, based on https://dxr.mozilla.org/mozilla-central/rev/4aed8e10318f38571712350856bf9e61c5f84e1f/tools/lint/eslint/eslint-plugin-mozilla/package.json#32-37

Since this, implicitly, enabled "prettier"[1] for the `extensions/firefox` directory a couple of small code changes were necessary as well.

---
[1] Generally speaking I'm wondering if that name is deliberately ironic, since the style it enforces is often times extremely weird and ugly :-P
@Snuffleupagus
Copy link
Collaborator Author

/botio lint

@pdfjsbot
Copy link

pdfjsbot commented Sep 7, 2019

From: Bot.io (Linux m4)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/74620c198e3c47e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 7, 2019

From: Bot.io (Windows)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/8691aa708eb3545/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 7, 2019

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/74620c198e3c47e/output.txt

Total script time: 0.91 mins

  • Lint: Passed

@pdfjsbot
Copy link

pdfjsbot commented Sep 7, 2019

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/8691aa708eb3545/output.txt

Total script time: 2.47 mins

  • Lint: Passed

@Snuffleupagus Snuffleupagus marked this pull request as ready for review September 7, 2019 11:00
@timvandermeij timvandermeij merged commit 4bf6119 into mozilla:master Sep 7, 2019
@timvandermeij
Copy link
Contributor

Good to be up-to-date again; thanks!

@Snuffleupagus Snuffleupagus deleted the eslint-plugin-mozilla branch September 7, 2019 22:48
@wojtekmaj wojtekmaj mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants