Fix the inconsistent return types for Dict.{get, getAsync}
#11171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having these methods fallback to returning `null` in only *one* particular case seems outright wrong, since a "falsy" value will thus be handled incorrectly. The only reason that this hasn't caused issues in practice is that there's only one call-site passing in three keys, and in that case we're trying to read a font file where falling back to `null` isn't a problem.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0def48869e790bb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/05a0e25e37af430/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/0def48869e790bb/output.txt Total script time: 17.71 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/05a0e25e37af430/output.txt Total script time: 26.07 mins
Image differences available at: http://54.215.176.217:8877/05a0e25e37af430/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Sep 23, 2019
|
The new situation looks much better. For reference, the only call-site is: Line 2557 in 9596d70 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having these methods fallback to returning
nullin only one particular case seems outright wrong, since a "falsy" value will thus be handled incorrectly.The only reason that this hasn't caused issues in practice is that there's only one call-site passing in three keys, and in that case we're trying to read a font file where falling back to
nullisn't a problem.