Convert the various image decoder ...Errors to classes extending BaseException (PR 11185 follow-up)
#11187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aseException` (PR 11185 follow-up) Somehow I missed these in PR 11185, but there's no good reason not to convert them as well.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/ae0146c468a00e5/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6e4d6271e3cd7e4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6e4d6271e3cd7e4/output.txt Total script time: 17.64 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/ae0146c468a00e5/output.txt Total script time: 26.15 mins
Image differences available at: http://54.215.176.217:8877/ae0146c468a00e5/reftest-analyzer.html#web=eq.log |
Snuffleupagus
changed the title
...Errors to classes extending `B…...Errors to classes extending BaseException (PR 11185 follow-up)
timvandermeij
approved these changes
Oct 1, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow I missed these in PR #11185, but there's no good reason not to convert them as well.