Re-factor StatTimer usage, in src/display/api.js, and remove DummyStatTimer
#11271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` exists when trying to report statistics Even though the currect situation only results in six unnecessary function calls per page, it nonetheless seems completely unnecessary to call dummy functions when `pdfBug` is *not* set (i.e. the default behaviour).
Since this isn't part of the API surface, removing it now that it's unused shouldn't cause any problems.
This argument is a left-over from older API code, where we unconditionally initialized `StatTimer` instances for every page. For quite some time that's only been done when `pdfBug` is set, hence it seems unnecessary to keep this functionality.
This uses template strings in a couple of spots, and a buffer in the `toString` method.
Snuffleupagus
force-pushed
the
rm-DummyStatTimer
branch
from
efa6f53
to
6f7f825
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/87b474c015b75b0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/96cdb39066c6cdd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/87b474c015b75b0/output.txt Total script time: 2.66 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/96cdb39066c6cdd/output.txt Total script time: 5.00 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/962be2d77945432/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/962be2d77945432/output.txt Total script time: 1.66 mins Published |
timvandermeij
approved these changes
Oct 23, 2019
|
Good simplification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.