Ensure that the peekByte methods, on the various Streams, handles end of data correctly (PR 5286 follow-up)
#11301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd of data correctly (PR 5286 follow-up) When the end of data has already been reached for the various Streams, the `getByte` methods will return `-1` to signal that to the caller. Note however that the current position obviously won't be incremented in this case, meaning that the `peekByte` methods will in this case *incorrectly* decrement the position. Thankfully the corresponding `peekBytes` shouldn't be affected by this bug, since they decrement the current position with the *actually* returned number of bytes. I'm not aware of any bugs caused by this blatant oversight, but that doesn't mean this shouldn't be fixed :-)
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/d8085246dd835f4/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1bfa83f0d62eafe/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/1bfa83f0d62eafe/output.txt Total script time: 18.62 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/d8085246dd835f4/output.txt Total script time: 26.61 mins
Image differences available at: http://54.215.176.217:8877/d8085246dd835f4/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Nov 1, 2019
|
Thank you for fixing this! |
|
Well, I did cause it so fixing it was probably the least I could do here :-) As always, thanks for reviewing and merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the end of data has already been reached for the various Streams, the
getBytemethods will return-1to signal that to the caller. Note however that the current position obviously won't be incremented in this case, meaning that thepeekBytemethods will in this case incorrectly decrement the position.Thankfully the corresponding
peekBytesshouldn't be affected by this bug, since they decrement the current position with the actually returned number of bytes.I'm not aware of any bugs caused by this blatant oversight, but that doesn't mean this shouldn't be fixed :-)