Slightly re-factor setting of the link target in addLinkAttributes
#11302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I happened to look at this code and the way that the link target is set seems unecessarily convoluted, since we're using `Object.values` and `Array.prototype.includes` for *every* link being parsed. Given that the number of link targets are so few, the easist solution honestly seem to be to just use a `switch` statement to do the link target mapping.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/cbee358bf2c05af/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/75f534f683834e6/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/cbee358bf2c05af/output.txt Total script time: 2.63 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/75f534f683834e6/output.txt Total script time: 5.32 mins
|
timvandermeij
approved these changes
Nov 2, 2019
|
I definitely agree with this; I also had to re-read the code to see how it worked. Thank you for simplifying this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I happened to look at this code and the way that the link target is set seems unecessarily convoluted, since we're using
Object.valuesandArray.prototype.includesfor every link being parsed.Given that the number of link targets are so few, the easist solution honestly seem to be to just use a
switchstatement to do the link target mapping.