Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Catalog.getPageDict to an async method #11312

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Convert Catalog.getPageDict to an async method #11312

merged 2 commits into from
Nov 8, 2019

Commits on Nov 8, 2019

  1. Convert Catalog.getPageDict to an async method 

    This makes it possible to remove the internal `next` helper function, and also gets rid of the need to manually resolve/reject a `PromiseCapability`.
    @Snuffleupagus
    Snuffleupagus committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    0d89006 View commit details
    Browse the repository at this point in the history

  2. Inline a couple of isRef/isDict checks in the getPageDict method 

    As we've seen in numerous other cases, avoiding unnecessary function calls is never a bad thing (even if the effect is probably tiny here).

With these changes we also avoid potentially two back-to-back `isDict` checks when evaluating possible Page nodes, and can also no longer accidentally pick a dictionary with an incorrect /Type.
    @Snuffleupagus
    Snuffleupagus committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    79d7c00 View commit details
    Browse the repository at this point in the history