Use getBytes, rather than looping over getByte, in FlateStream.prototype.readBlock
#11334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rototype.readBlock` *Please note:* A a similar change was attempted in PR 5005, but it was subsequently backed out (in PR 5069) since other parts of the patch caused issues. With these changes, it's possible to replace repeated function calls within a loop with just a single function call and subsequent assignment instead.
Snuffleupagus
force-pushed
the
FlateStream-readBlock-getBytes
branch
from
dad43c1
to
688d155
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/fc02954c5e038ee/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/fd9704a6829c907/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/fd9704a6829c907/output.txt Total script time: 18.63 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/fc02954c5e038ee/output.txt Total script time: 26.71 mins
Image differences available at: http://54.215.176.217:8877/fc02954c5e038ee/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Nov 16, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: A a similar change was attempted in PR #5005, but it was subsequently backed out (in PR #5069) since other parts of the patch caused issues.
With these changes, it's possible to replace repeated function calls within a loop with just a single function call and subsequent assignment instead.