Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplication when registering event listeners for the Toolbar buttons, and other small clean-up #11338

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Reduce duplication when registering event listeners for the Toolbar buttons, and other small clean-up #11338

merged 3 commits into from
Nov 19, 2019

Commits on Nov 17, 2019

  1. Reduce duplication when registering event listeners for the Toolbar… 

    … buttons

This uses the same kind of format as is being used in the `SecondaryToolbar` class.
    @Snuffleupagus
    Snuffleupagus committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    3edaebb View commit details
    Browse the repository at this point in the history

  2. Use for...of in a couple of loops in web/toolbar.js and `web/seco… 

    …ndary_toolbar.js`
    @Snuffleupagus
    Snuffleupagus committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    eaa2e21 View commit details
    Browse the repository at this point in the history

  3. Inline the Toolbar._localized method in the 'localized' event handler 

    Considering just how small/simple this code is, it doesn't seem necessary to have a separate method for it (even more so when there's only one call-site).
    @Snuffleupagus
    Snuffleupagus committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    07473e9 View commit details
    Browse the repository at this point in the history