Convert {BaseViewer, PDFThumbnailViewer}._pagesRequests from an Array to a WeakMap
#11350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay to a WeakMap Obviously the `_pagesRequests` functionality is *mainly* used when `disableAutoFetch` is set, but it will also be used during ranged/streamed loading of documents. However, the `_pagesRequests` property is currently an Array which seems a bit strange: - Arrays are zero-indexed, but the first element will never actually be set in the code. - The `_pagesRequests` Array is never cleared, unless a new document is loaded, and once the `PDFDocumentProxy.getPage` call has resolved/rejected the element is just replaced by `null`. - Unless the document is browsed *in order* the resulting `_pagesRequests` Array can also be arbitrarily sparse. All in all, I don't believe that an Array is an appropriate data structure to use for this purpose.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/106ad4cc926949c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/106ad4cc926949c/output.txt Total script time: 1.70 mins Published |
timvandermeij
approved these changes
Nov 21, 2019
|
Good improvement, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously the
_pagesRequestsfunctionality is mainly used whendisableAutoFetchis set, but it will also be used during ranged/streamed loading of documents.However, the
_pagesRequestsproperty is currently an Array which seems a bit strange:_pagesRequestsArray is never cleared, unless a new document is loaded, and once thePDFDocumentProxy.getPagecall has resolved/rejected the element is just replaced bynull._pagesRequestsArray can also be arbitrarily sparse.All in all, I don't believe that an Array is an appropriate data structure to use for this purpose.