Slightly simplify the XRef cache lookup in XRef.fetch
#11373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the XRef cache will only hold objects returned through `Parser.getObj`, and indirectly via `Lexer.getObj`. Since neither of those methods will ever return `undefined`, we can simply `assert` that when inserting objects into the cache and thus get rid of one function call when doing cache lookups. Obviously this won't have a huge effect on performance, however `XRef.fetch` is usually called *a lot* in larger documents and this patch thus cannot hurt.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/515536639860995/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/31daca6922bb070/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/515536639860995/output.txt Total script time: 18.73 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/31daca6922bb070/output.txt Total script time: 26.49 mins
|
timvandermeij
approved these changes
Dec 1, 2019
|
Looks like a useful change to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the XRef cache will only hold objects returned through
Parser.getObj, and indirectly viaLexer.getObj. Since neither of those methods will ever returnundefined, we can simplyassertthat when inserting objects into the cache and thus get rid of one function call when doing cache lookups.Obviously this won't have a huge effect on performance, however
XRef.fetchis usually called a lot in larger documents and this patch thus cannot hurt.