Set the first pdfPage immediately in {BaseViewer, PDFThumbnailViewer}.setDocument
#11374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er}.setDocument`
*This patch is simple enough that I almost feel like I'm overlooking some trivial reason why this would be a bad idea.*
Note how in `{BaseViewer, PDFThumbnailViewer}.setDocument` we're always getting the *first* `pdfPage` in order to initialize all pages/thumbnails.
However, once that's done the first `pdfPage` is simply ignored and rendering of the first page thus requires calling `PDFDocumentProxy.getPage` yet again. (And in the `BaseViewer` case, it's even done once more after `onePageRenderedCapability` is resolved.)
All in all, I cannot see why we cannot just immediately set the first `pdfPage` and thus avoid an early round-trip to the API in the `_ensurePdfPageLoaded` method before rendering can begin.
Snuffleupagus
force-pushed
the
set-first-pdfPage
branch
from
9695174
to
6732df6
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6e5392cc21e8326/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6e5392cc21e8326/output.txt Total script time: 1.71 mins Published |
timvandermeij
approved these changes
Dec 1, 2019
I'm also a bit puzzled by this and I can't imagine why we wouldn't use it if it's already loaded. The patch looks good to me; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is simple enough that I almost feel like I'm overlooking some trivial reason why this would be a bad idea.
Note how in
{BaseViewer, PDFThumbnailViewer}.setDocumentwe're always getting the firstpdfPagein order to initialize all pages/thumbnails.However, once that's done the first
pdfPageis simply ignored and rendering of the first page thus requires callingPDFDocumentProxy.getPageyet again. (And in theBaseViewercase, it's even done once more afteronePageRenderedCapabilityis resolved.)All in all, I cannot see why we cannot just immediately set the first
pdfPageand thus avoid an early round-trip to the API in the_ensurePdfPageLoadedmethod before rendering can begin.