Fix an incorrect condition in BaseViewer.isPageVisible (PR 10217 follow-up)
#11382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llow-up) This was a blatant oversight in PR 10217, since there's obviously no `this.pageNumber` property anywhere in the `BaseViewer`. Luckily this shouldn't have caused any bugs, since the only call-site is also validating the `pageNumber` (but correctly that time).
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/54b134038b66b66/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/54b134038b66b66/output.txt Total script time: 1.72 mins Published |
timvandermeij
approved these changes
Dec 8, 2019
|
Hm, I also managed to overlook this during review. Thank you for the follow-up fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a blatant oversight in PR #10217, since there's obviously no
this.pageNumberproperty anywhere in theBaseViewer. Luckily this shouldn't have caused any bugs, since the only call-site is also validating thepageNumber(but correctly that time).