Attempt to improve the PDFDocument error message for empty files (issue 5887)
#11398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue 5887) Given that the error in question is surfaced on the API-side, this patch makes the following changes: - Updates the wording such that it'll hopefully be slightly easier for users to understand. - Changes the plain `Error` to an `InvalidPDFException` instead, since that should work better with the existing Error handling. - Adds a unit-test which loads an empty PDF document (and also improves a pre-existing `InvalidPDFException` message and its test-case).
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e75d77ffd2ee001/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6d661935b6e9236/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e75d77ffd2ee001/output.txt Total script time: 18.83 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6d661935b6e9236/output.txt Total script time: 26.47 mins
|
timvandermeij
approved these changes
Dec 9, 2019
|
That should indeed be a more clear message. Thanks, also for adding a unit test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the error in question is surfaced on the API-side, this patch makes the following changes:
Errorto anInvalidPDFExceptioninstead, since that should work better with the existing Error handling.InvalidPDFExceptionmessage and its test-case).Fixes #5887