Re-factor the npm test command, used by Travis, to avoid running the 'default_preferences' tasks concurrently (issue 10732)
#11413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e 'default_preferences' tasks concurrently (issue 10732) *Please note:* This patch does *not* prevent the 'default_preferences' task from running more than once during `npm test`, but it does ensure that the tasks won't run *concurrently* by running the relevant tests in *series*. While it would obviously still make sense to re-factor the gulpfile to account for changes in `gulp` version 4, by at least tweaking the `npm test` command the intermittent failures on Travis should at least go away.
|
I agree. It would be helpful to at least get rid of the intermittent failures and fix the issues regarding Gulp 4 changes in a separate scope. |
timvandermeij
approved these changes
Dec 18, 2019
Yeah, that was my thought as well (since a proper Gulp 4 migration is a larger undertaking); and I had trouble following all the changes in the other PR (and it doesn't seem to prevent the concurrency issue either). |
|
Thank you for improving the situation here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: This patch does not prevent the 'default_preferences' task from running more than once during
npm test, but it does ensure that the tasks won't run concurrently by running the relevant tests in series.While it would obviously still make sense to re-factor the gulpfile to account for changes in
gulpversion 4, by at least tweaking thenpm testcommand the intermittent failures on Travis should at least go away.