Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that all import and require statements, in the entire code-base, have a .js file extension #11465

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Ensure that all import and require statements, in the entire code-base, have a .js file extension #11465

merged 1 commit into from
Jan 6, 2020

Conversation

Snuffleupagus
Copy link
Collaborator

In order to eventually get rid of SystemJS and start using native imports instead, we'll need to provide "complete" file identifiers since otherwise there'll be MIME type errors when attempting to use import.

@pdfjsbot
Copy link

pdfjsbot commented Jan 2, 2020

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/9c6a88e15988ce8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 2, 2020

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/9c6a88e15988ce8/output.txt

Total script time: 1.71 mins

Published

@Snuffleupagus
Ensure that all import and require statements, in the entire code…
36881e3 
…-base, have a `.js` file extension

In order to eventually get rid of SystemJS and start using native `import`s instead, we'll need to provide "complete" file identifiers since otherwise there'll be MIME type errors when attempting to use `import`.
@pdfjsbot
Copy link

pdfjsbot commented Jan 6, 2020

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.67.70.0:8877/39101d74c6229e2/output.txt

@Snuffleupagus Snuffleupagus marked this pull request as ready for review January 6, 2020 10:06
@pdfjsbot
Copy link

pdfjsbot commented Jan 6, 2020

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/39101d74c6229e2/output.txt

Total script time: 1.73 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jan 6, 2020

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c43f7f6bb6b4b2c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 6, 2020

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/858761ebb7f2aad/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 6, 2020

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/c43f7f6bb6b4b2c/output.txt

Total script time: 18.68 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jan 6, 2020

From: Bot.io (Windows)

Failed

Full output at http://54.215.176.217:8877/858761ebb7f2aad/output.txt

Total script time: 60.00 mins

@timvandermeij timvandermeij merged commit 93aa613 into mozilla:master Jan 6, 2020
@timvandermeij
Copy link
Contributor

Looks good! Let's hope the Windows bot starts working again, otherwise we'll have to kick it.

@timvandermeij timvandermeij mentioned this pull request Jan 6, 2020
Closed
@Snuffleupagus Snuffleupagus deleted the import-file-extension branch January 6, 2020 22:59
@tamuratak tamuratak mentioned this pull request Jan 17, 2020
Merged
tamuratak added a commit to tamuratak/pdf.js that referenced this pull request Jan 17, 2020
@tamuratak
Enable import/extensions of ESlint plugin to enforce all import hav…
4f243b8 
…e a `.js` file extension.

Related to mozilla#11465.

- https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/extensions.md
tamuratak added a commit to tamuratak/pdf.js that referenced this pull request Jan 18, 2020
@tamuratak
Enable import/extensions of ESlint plugin to enforce all import hav…
00ce789 
…e a `.js` file extension.

Related to mozilla#11465.

- https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/extensions.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
core viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @pdfjsbot @timvandermeij