Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of cases where Prettier broke existing formatting (PR 11446 follow-up) #11502

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

Snuffleupagus
Copy link
Collaborator

These two cases should have been whitelisted prior to re-formatting respectively had the comments fixed afterwards, however I unfortunately missed them because of the massive size of the diff.

@Snuffleupagus Snuffleupagus changed the title Fix a couple of cases where the Prettier broke existing formatting (PR 11446 follow-up) Fix a couple of cases where Prettier broke existing formatting (PR 11446 follow-up) Jan 11, 2020
…446 follow-up)

These two cases should have been whitelisted prior to re-formatting respectively had the comments fixed afterwards, however I unfortunately missed them because of the massive size of the diff.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.67.70.0:8877/e14012d4ef98ec3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.215.176.217:8877/63693b23bfccbff/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/e14012d4ef98ec3/output.txt

Total script time: 19.36 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/e14012d4ef98ec3/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/63693b23bfccbff/output.txt

Total script time: 26.01 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/63693b23bfccbff/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit be5b009 into mozilla:master Jan 22, 2020
@timvandermeij
Copy link
Contributor

Yes, the size of the diff made this pretty much impossible to catch. Thanks!

@Snuffleupagus Snuffleupagus deleted the prettier-followup-fixes branch January 22, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants