Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unused sizes and encoding properties on Font instances #11755

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Remove the unused sizes and encoding properties on Font instances #11755

merged 1 commit into from
Mar 27, 2020

Commits on Mar 27, 2020

  1. Remove the unused sizes and encoding properties on Font instances 

    The `sizes` property doesn't appear to have been used ever since the code was first split into main/worker-threads, which is so many years ago that I wasn't able to easily find exactly in which PR/commit it became unused.

The `encoding` property is always assigned the `properties.baseEncoding` value, however the `PartialEvaluator` doesn't actually compute/set that value any more. Again it was difficult to determine when it became unused, but it's been that way for years.
    @Snuffleupagus
    Snuffleupagus committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    14c999e View commit details
    Browse the repository at this point in the history