Gracefully handle annotation parsing errors in Page.getOperatorList (issue 11871)
#11872
Conversation
… (issue 11871) This should ensure that a page will always render successfully, even if there's errors during the Annotation fetching/parsing. Additionally the `OperatorList.addOpList` method is also adjusted to ignore invalid data, to make it slightly more robust.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ebf160badd2d2df/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/f986c74a90f2e00/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/ebf160badd2d2df/output.txt Total script time: 25.64 mins
Image differences available at: http://54.67.70.0:8877/ebf160badd2d2df/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/f986c74a90f2e00/output.txt Total script time: 27.54 mins
Image differences available at: http://54.215.176.217:8877/f986c74a90f2e00/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d5cd2efc3f8ba74/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d5cd2efc3f8ba74/output.txt Total script time: 3.29 mins Published |
|
Thanks! |
|
I have not made reference images on purpose because of the broken fonts in Firefox Nightly. I considered changing Puppeteer to use another Firefox version, but I noticed that the problem in https://bugzilla.mozilla.org/show_bug.cgi?id=1607630 has been tracked down, so if a solution is merged in the coming days we'll get it automatically and we can makeref in another patch. If the upstream solution takes too long, we should be able to still switch (given that I did not try this before, I'd much rather have this fixed upstream instead, especially since we need to upgrade sooner or later anyway). |
This should ensure that a page will always render successfully, even if there's errors during the Annotation fetching/parsing.
Additionally the
OperatorList.addOpListmethod is also adjusted to ignore invalid data, to make it slightly more robust.Fixes #11871