Reduce usage of SystemJS, in the development viewer, even further #11919
Conversation
Snuffleupagus
force-pushed
the
less-SystemJS
branch
from
44ed933
to
1acd995
Compare
With these changes SystemJS is now only used, during development, on the worker-thread and in the unit/font-tests, since Firefox is currently missing support for worker modules; please see https://bugzilla.mozilla.org/show_bug.cgi?id=1247687 Hence all the JavaScript files in the `web/` and `src/display/` folders are now loaded *natively* by the browser (during development) using standard `import` statements/calls, thanks to a nice `import-maps` polyfill. *Please note:* As soon as https://bugzilla.mozilla.org/show_bug.cgi?id=1247687 is fixed in Firefox, we should be able to remove all traces of SystemJS and thus finally be able to use every possible modern JavaScript feature.
Snuffleupagus
force-pushed
the
less-SystemJS
branch
from
1acd995
to
8d56a69
Compare
|
Most of the testing of this patch will unfortunately need to be done locally, and manually, since the changes shouldn't affect the built files in any way... /botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3457289ce8994c1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.215.176.217:8877/80cee0abd61d2c9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/3457289ce8994c1/output.txt Total script time: 26.11 mins
Image differences available at: http://54.67.70.0:8877/3457289ce8994c1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/80cee0abd61d2c9/output.txt Total script time: 28.28 mins
Image differences available at: http://54.215.176.217:8877/80cee0abd61d2c9/reftest-analyzer.html#web=eq.log |
|
It seems that https://bugzilla.mozilla.org/show_bug.cgi?id=1607630 has landed in Nightly now, let's see if this works... /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/08a0d2a78bb408e/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3cb993c3ee0a0a3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/3cb993c3ee0a0a3/output.txt Total script time: 24.35 mins
|
|
Seems to work just fine locally. Thanks! |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/08a0d2a78bb408e/output.txt Total script time: 27.57 mins
|
With these changes SystemJS is now only used, during development, on the worker-thread and in the unit/font-tests, since Firefox is currently missing support for worker modules; please see https://bugzilla.mozilla.org/show_bug.cgi?id=1247687
Hence all the JavaScript files in the
web/andsrc/display/folders are now loaded natively by the browser (during development) using standardimportstatements/calls, thanks to a niceimport-mapspolyfill.Please note: As soon as https://bugzilla.mozilla.org/show_bug.cgi?id=1247687 is fixed in Firefox, we should be able to remove all traces of SystemJS and thus finally be able to use every possible modern JavaScript feature.
Depends upon, and includes, PR #11914
Fixes #10965 (given that it doesn't make much sense to spend time and effort on that now, since SystemJS is now used a lot less and that it'll hopefully be gone completely somewhat soon).