Add comments to the export list in the src/pdf.js file (PR 11914 follow-up)
#11940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…follow-up) When converting this file to use standard `import`/`export` statements, I sorted the exports in the same order as the imports to simplify things. However, looking at the list of `export`ed properties it probably doesn't hurt to add a couple of comments to clarify from where specifically the `export`s originated.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3b9634077a49013/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/5f38d93bdd339b8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/3b9634077a49013/output.txt Total script time: 3.70 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/5f38d93bdd339b8/output.txt Total script time: 4.62 mins
|
timvandermeij
approved these changes
May 27, 2020
|
Good idea! It's indeed quite a big list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting this file to use standard
import/exportstatements, I sorted the exports in the same order as the imports to simplify things.However, looking at the list of
exported properties it probably doesn't hurt to add a couple of comments to clarify from where specifically theexports originated.