A couple of small image caching/sending improvements #11974
Conversation
…ImageCache.getData` We can simply attempt to get the data *directly*, and instead check the result, rather than first checking if it exists.
…uildPaintImageXObject` method After PRs 10727 and 11912, the code responsible for sending the decoded image data to the main-thread has now become a fair bit more involved the previously. To reduce the amount of duplication here, the actual code responsible for sending the data is thus extracted into a new helper method instead.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9ed9bf9ce425330/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/810f4968c17b5df/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/9ed9bf9ce425330/output.txt Total script time: 25.68 mins
Image differences available at: http://54.67.70.0:8877/9ed9bf9ce425330/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/810f4968c17b5df/output.txt Total script time: 29.87 mins
Image differences available at: http://54.215.176.217:8877/810f4968c17b5df/reftest-analyzer.html#web=eq.log |
|
Thanks! /botio makeref (in the hope to remove some failures) |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b511c817545adf4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/d1a2cb04726ef98/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b511c817545adf4/output.txt Total script time: 23.90 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/d1a2cb04726ef98/output.txt Total script time: 26.06 mins
|
Remove an unnecessary
RefSetCache.prototype.has()call fromGlobalImageCache.getDataWe can simply attempt to get the data directly, and instead check the result, rather than first checking if it exists.
Extract the actual sending of image data from the
PartialEvaluator.buildPaintImageXObjectmethodAfter PRs Support (rare) Type3 fonts which contains image resources (issue 10717) #10727 and Attempt to cache repeated images at the document, rather than the page, level (issue 11878) #11912, the code responsible for sending the decoded image data to the main-thread has now become a fair bit more involved the previously.
To reduce the amount of duplication here, the actual code responsible for sending the data is thus extracted into a new helper method instead.