Improve (local) caching of parsed ColorSpaces (PR 12001 follow-up)
#12012
Conversation
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/aecf22498af18e1/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3ffee2b80de75bb/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/aecf22498af18e1/output.txt Total script time: 28.06 mins
Image differences available at: http://54.215.176.217:8877/aecf22498af18e1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/3ffee2b80de75bb/output.txt Total script time: 60.00 mins |
Snuffleupagus
force-pushed
the
ColorSpace-parse-cache
branch
9 times, most recently
from
abc37b7
to
c2e25f0
Compare
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/68f0aaf45eb8443/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f4a9cf9a23f9609/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/f4a9cf9a23f9609/output.txt Total script time: 25.44 mins
Image differences available at: http://54.67.70.0:8877/f4a9cf9a23f9609/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/68f0aaf45eb8443/output.txt Total script time: 29.72 mins
Image differences available at: http://54.215.176.217:8877/68f0aaf45eb8443/reftest-analyzer.html#web=eq.log |
Snuffleupagus
force-pushed
the
ColorSpace-parse-cache
branch
3 times, most recently
from
eb3a6ff
to
39a1587
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/95a68e86860315d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/4802e4c61eb3764/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/95a68e86860315d/output.txt Total script time: 25.98 mins
Image differences available at: http://54.67.70.0:8877/95a68e86860315d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/4802e4c61eb3764/output.txt Total script time: 29.25 mins
Image differences available at: http://54.215.176.217:8877/4802e4c61eb3764/reftest-analyzer.html#web=eq.log |
Snuffleupagus
force-pushed
the
ColorSpace-parse-cache
branch
2 times, most recently
from
bf74dc6
to
8adab78
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a86eced09e86690/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/8928e8a71692b26/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/a86eced09e86690/output.txt Total script time: 25.73 mins
Image differences available at: http://54.67.70.0:8877/a86eced09e86690/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/8928e8a71692b26/output.txt Total script time: 29.24 mins
Image differences available at: http://54.215.176.217:8877/8928e8a71692b26/reftest-analyzer.html#web=eq.log |
…a bunch of (randomly) ordered parameters Given the number of existing parameters, this will avoid needlessly unwieldy call-sites especially with upcoming changes in later patches.
…n the image one (PR 12001 follow-up) This will allow caching of ColorSpaces by either `Name` *or* `Ref`, which doesn't really make sense for images, thus allowing (better) caching for ColorSpaces used with e.g. Images and Patterns.
This patch contains the following *notable* improvements: - Changes the `ColorSpace.parse` call-sites to, where possible, pass in a reference rather than actual ColorSpace data (necessary for the next point). - Adds (local) caching of `ColorSpace`s by `Ref`, when applicable, in addition the caching by name. This (generally) improves `ColorSpace` caching for e.g. the SMask code-paths. - Extends the (local) `ColorSpace` caching to also apply when handling Images and Patterns, thus further reducing unneeded re-parsing. - Adds a new `ColorSpace.parseAsync` method, almost identical to the existing `ColorSpace.parse` one, but returning a Promise instead (this simplifies some code in the `PartialEvaluator`).
…ntry of `ICCBased` ColorSpaces (PR 9659 follow-up) With the changes made in PR 9659, `ColorSpace.fromIR` no longer takes a second `pdfFunctionFactory` parameter and there's thus one call-site that can be simplified.
Snuffleupagus
force-pushed
the
ColorSpace-parse-cache
branch
from
8adab78
to
b8e1352
Compare
|
Thank you for working on this! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9e4fb39ba5402ca/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/b8958604b42aa14/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9e4fb39ba5402ca/output.txt Total script time: 24.06 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/b8958604b42aa14/output.txt Total script time: 27.64 mins
|
|
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/9b87ddc8169ad8d/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/9b87ddc8169ad8d/output.txt Total script time: 26.91 mins
|
As always, thanks for landing the PR! (I'm currently looking into caching of parsed Functions, which may further improve some documents.) |
This patch contains the following notable improvements:
ColorSpace.parsecall-sites to, where possible, pass in a reference rather than actual ColorSpace data (necessary for the next point).ColorSpaces byRef, when applicable, in addition the caching by name. This (generally) improvesColorSpacecaching for e.g. the SMask code-paths.ColorSpacecaching to also apply when handling Images and Patterns, thus further reducing unneeded re-parsing.ColorSpace.parseAsyncmethod, almost identical to the existingColorSpace.parseone, but returning a Promise instead (this simplifies some code in thePartialEvaluator).