Update Needle to 2.5.0 or greater. #12024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions of `needle` prior to `2.5.0` cannot cope with redirects (as documented: tomas/needle#312). This prevents prebuilt `canvas` binaries from being downloaded on MacOS, requiring the global install of its dependencies. Updating Needle restores it to functionality, addressing this. It also avoids the need to add `request` to `package.json`; it also obsoletes mozilla#12018.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7b64bca52b810b1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7b64bca52b810b1/output.txt Total script time: 3.43 mins Published |
timvandermeij
approved these changes
Jun 26, 2020
|
Let's do this. Thank you! |
timvandermeij
added a commit
to timvandermeij/pdf.js
that referenced
this pull request
May 16, 2024
The `needle` dependency originally got introduced in mozilla#12024, almost four years ago, to be able to use pre-built binaries for the `canvas` dependency on macOS. However, nowadays the `needle` dependency isn't used by `canvas` anymore, or any other package we use for that matter, as shown by the empty NPM dependency tree: ``` $ npm ls needle pdf.js └── needle@3.3.1 ``` Investigation showed that the `canvas` package depends on the `node-pre-gyp` package which in turn depended on `needle` (see Automattic/node-canvas#1110 (comment)), but in version 1.0.0 of `node-pre-gyp` from three years ago the `needle` dependency got dropped in favor of `node-fetch`. This explains why the NPM dependency tree is empty now and proves that we can safely get rid of this dependency.
timvandermeij
added a commit
to timvandermeij/pdf.js
that referenced
this pull request
May 16, 2024
The `needle` dependency originally got introduced in mozilla#12024, almost four years ago, to be able to use pre-built binaries for the `canvas` dependency on macOS. However, nowadays the `needle` dependency isn't used by `canvas` anymore, or any other package we use for that matter, as shown by the empty NPM dependency tree: ``` $ npm ls needle pdf.js └── needle@3.3.1 ``` Investigation showed that the `canvas` package depends on the `node-pre-gyp` package which in turn depended on `needle` (see Automattic/node-canvas#1110 (comment)), but in version 1.0.0 of `node-pre-gyp` from three years ago the `needle` dependency got dropped in favor of `node-fetch` (see https://github.com/mapbox/node-pre-gyp/blob/a74f5e367c0d71033620aa0112e7baf7f3515b9d/CHANGELOG.md?plain=1#L52). This explains why the NPM dependency tree is empty now and proves that we can safely get rid of this dependency now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of
needleprior to2.5.0cannot cope with redirects (as documented).This prevents prebuilt
canvasbinaries from being downloaded on MacOS,requiring the global install of its dependencies.
Updating
needlerestores it to functionality, addressing this. This change avoidsthe need to add
requesttopackage.jsonor bundle pre-built binaries, it also obsoletes #12018.(NB: needle was already in use for this package.)