Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] Add an annotation storage in order to save annotation data in acroforms #12106

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

calixteman
Copy link
Contributor

The goal of this storage is to be able to save form data from the html layer and then be able to print and save them.

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with these comments addressed. Thank you for splitting this up so we can get this merged soon!

src/core/worker.js Outdated Show resolved Hide resolved
src/display/annotation_layer.js Outdated Show resolved Hide resolved
src/display/annotation_storage.js Outdated Show resolved Hide resolved
src/display/annotation_storage.js Outdated Show resolved Hide resolved
src/display/annotation_storage.js Outdated Show resolved Hide resolved
src/display/annotation_storage.js Outdated Show resolved Hide resolved
src/display/annotation_storage.js Outdated Show resolved Hide resolved
src/display/annotation_storage.js Outdated Show resolved Hide resolved
src/display/api.js Outdated Show resolved Hide resolved
test/unit/jasmine-boot.js Outdated Show resolved Hide resolved
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge with the final comment addressed and the commits squashed into one. Thank you!

src/display/annotation_storage.js Outdated Show resolved Hide resolved
@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/199cc242864ef1f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/71ad1238be356a2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/199cc242864ef1f/output.txt

Total script time: 26.73 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/199cc242864ef1f/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/71ad1238be356a2/output.txt

Total script time: 30.87 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/71ad1238be356a2/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit bf539de into mozilla:master Jul 24, 2020
@timvandermeij
Copy link
Contributor

First part done; thank you!

@lundjordan lundjordan added the Gecko 81 Tracking work planned for Form Fill in Shirley 81 release label Jul 27, 2020
@timvandermeij timvandermeij changed the title Add an annotation storage in order to save annotation data in acroforms [api-minor] Add an annotation storage in order to save annotation data in acroforms Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotations form-acroform Gecko 81 Tracking work planned for Form Fill in Shirley 81 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants