-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the browser name when printing unit-test results #12124
Include the browser name when printing unit-test results #12124
Conversation
This uses a similar format to the reference-test logging, and will help determine in *exactly* which browser the failure occurred (since the tests run concurrently).
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/9268371d2bd5e76/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/dc69c4f5293e4ab/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/dc69c4f5293e4ab/output.txt Total script time: 3.86 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/9268371d2bd5e76/output.txt Total script time: 4.77 mins
|
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6b2f546c36e0e21/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/152acc6c28316b9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/152acc6c28316b9/output.txt Total script time: 3.79 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6b2f546c36e0e21/output.txt Total script time: 4.68 mins
|
Interestingly, the failing unit-tests seem to (as I suspected) be limited to Google Chrome on Linux. |
I have made #12125 to hopefully improve the situation a bit. I can reproduce the intermittent unit tests failures for Chrome on Linux, but with that patch it seems to have fewer tests failures and also less frequent. We'll see... |
Thanks, fingers crossed that it helps :-) Anyway, I do believe that this patch is useful regardless since it makes the logs easier to read. |
Thanks! |
This uses a similar format to the reference-test logging, and will help determine in exactly which browser the failure occurred (since the tests run concurrently).