Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the browser name when printing unit-test results #12124

Merged
merged 1 commit into from
Jul 26, 2020

Conversation

Snuffleupagus
Copy link
Collaborator

This uses a similar format to the reference-test logging, and will help determine in exactly which browser the failure occurred (since the tests run concurrently).

This uses a similar format to the reference-test logging, and will help determine in *exactly* which browser the failure occurred (since the tests run concurrently).
@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/9268371d2bd5e76/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/dc69c4f5293e4ab/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/dc69c4f5293e4ab/output.txt

Total script time: 3.86 mins

  • Unit Tests: FAILED

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/9268371d2bd5e76/output.txt

Total script time: 4.77 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/6b2f546c36e0e21/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/152acc6c28316b9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/152acc6c28316b9/output.txt

Total script time: 3.79 mins

  • Unit Tests: FAILED

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/6b2f546c36e0e21/output.txt

Total script time: 4.68 mins

  • Unit Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

Interestingly, the failing unit-tests seem to (as I suspected) be limited to Google Chrome on Linux.

@timvandermeij
Copy link
Contributor

timvandermeij commented Jul 26, 2020

I have made #12125 to hopefully improve the situation a bit. I can reproduce the intermittent unit tests failures for Chrome on Linux, but with that patch it seems to have fewer tests failures and also less frequent. We'll see...

@Snuffleupagus
Copy link
Collaborator Author

I have made #12125 to hopefully improve the situation a bit.

Thanks, fingers crossed that it helps :-)


Anyway, I do believe that this patch is useful regardless since it makes the logs easier to read.

@timvandermeij timvandermeij merged commit 7ffbda3 into mozilla:master Jul 26, 2020
@timvandermeij
Copy link
Contributor

Thanks!

@Snuffleupagus Snuffleupagus deleted the unittest-browser-name branch July 26, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants