Attempt to reduce intermittent failures in the "cleans up document resources during rendering of page" unit-test #12126
Conversation
…sources during rendering of page" unit-test This patch should *hopefully* remove the `Unhandled promise rejection: ...` errors, by returning the "final" promise. Also, by pausing/delaying of rendering slightly the likelihood of the test failing in the first place should thus be reduced.
|
/botio-linux unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e1ea7b64a0631c9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/e1ea7b64a0631c9/output.txt Total script time: 3.78 mins
|
|
/botio-linux unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/436e23ba62d1bf7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/436e23ba62d1bf7/output.txt Total script time: 3.80 mins
|
|
/botio-linux unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9cfd3fc9938b818/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/9cfd3fc9938b818/output.txt Total script time: 3.79 mins
|
|
Nice find! It hasn't failed anymore and it's also more consistent with the unit tests above it where the cleanup promise is also returned. |
This patch should hopefully remove the
Unhandled promise rejection: ...errors, by returning the "final" promise. Also, by pausing/delaying of rendering slightly the likelihood of the test failing in the first place should thus be reduced.