Wait until saving has finished before resetting PDFViewerApplication._saveInProgress (PR 12137 follow-up)
#12211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…._saveInProgress` (PR 12137 follow-up) I obviously missed this during review, but currently `PDFViewerApplication._saveInProgress` is reset *synchronously* in `PDFViewerApplication.save`. That was probably not intended, since it essentially renders the `PDFViewerApplication._saveInProgress` check pointless given that the actual saving is an *asynchronous* operation.
Snuffleupagus
force-pushed
the
_saveInProgress-reset
branch
from
d74dbde
to
22cb59e
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/cc3ad67b94c314a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/cc3ad67b94c314a/output.txt Total script time: 3.25 mins Published |
timvandermeij
added
annotations
form-acroform
Gecko 81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I obviously missed this during review, but currently
PDFViewerApplication._saveInProgressis reset synchronously inPDFViewerApplication.save.That was probably not intended, since it essentially renders the
PDFViewerApplication._saveInProgresscheck pointless given that the actual saving is an asynchronous operation.