Include image_decoders-es5/minified-es5 in the pdfjs-dist library (issue 12220)
#12227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this will increase the run-time of `gulp dist` and `gulp dist-install`, but that's unavoidable given that there's now additional building happening.
Snuffleupagus
force-pushed
the
dist-more-es5
branch
from
d6635ae
to
e079c18
Compare
timvandermeij
approved these changes
Aug 17, 2020
|
Tested locally and this seems to work just fine. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
image_decoders-es5gulp task, and include it in thepdfjs-distlibraryInclude
minified-es5in thepdfjs-distlibrary (issue 11892)Note that this will increase the run-time of
gulp distandgulp dist-install, but that's unavoidable given that there's now additional building happening.Fixes #12220