Dispatch event when annotations have finished rendering. #12229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvandermeij
added
the
Gecko 81
Snuffleupagus
requested changes
Aug 17, 2020
brendandahl
force-pushed
the
ann-event
branch
2 times, most recently
from
4db9228
to
01c1b86
Compare
|
Looks good with the two final comments above addressed. |
timvandermeij
approved these changes
Aug 17, 2020
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 1 Live output at: http://54.67.70.0:8877/fd6f52468ad7338/output.txt |
This is needed for some smoke tests in mozilla central for testing forms in pdf.js. Note: AnnotationLayerBuilder.render() doesn't really need to be async, but we're talking of making the annotation's render functions async, so this will make that switch easier.
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/fd6f52468ad7338/output.txt Total script time: 0.13 mins |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/07ab5a71bbd3c2d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/07ab5a71bbd3c2d/output.txt Total script time: 3.32 mins Published |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for some smoke tests in mozilla central for testing forms
in pdf.js.
Note: AnnotationLayerBuilder.render() doesn't really need to be async, but
we're talking of making the annotation's render functions async, so this
will make that switch easier.