Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save form data in XFA datasets when pdf is a mix of acroforms and xfa #12344

Merged
merged 5 commits into from
Sep 8, 2020
Merged

Save form data in XFA datasets when pdf is a mix of acroforms and xfa #12344

merged 5 commits into from
Sep 8, 2020

Conversation

calixteman
Copy link
Contributor

This patch aims to fix issue #12319.

@brendandahl
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2020

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/0f0ba501732c881/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2020

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/f6c645098411f5e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2020

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/f6c645098411f5e/output.txt

Total script time: 27.21 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/f6c645098411f5e/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2020

From: Bot.io (Windows)

Failed

Full output at http://54.215.176.217:8877/0f0ba501732c881/output.txt

Total script time: 29.47 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/0f0ba501732c881/reftest-analyzer.html#web=eq.log

timvandermeij
timvandermeij reviewed Sep 8, 2020
View reviewed changes
src/core/worker.js Outdated Show resolved Hide resolved
@brendandahl brendandahl merged commit 68b99c5 into mozilla:master Sep 8, 2020
@timvandermeij timvandermeij mentioned this pull request Sep 8, 2020
Closed
@timvandermeij
Copy link
Contributor

@calixteman Now that this is merged, it would be great if you could make a follow-up PR that addresses the two comments above. Thanks!

calixteman added a commit to calixteman/pdf.js that referenced this pull request Sep 9, 2020
@calixteman
Follow-up of pr mozilla#12344
64a6efd
timvandermeij added a commit that referenced this pull request Sep 9, 2020
@timvandermeij
Merge pull request #12349 from calixteman/followup_12344
f9d5632 
Follow-up of pr #12344
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 10, 2020
@rvandermeulen
Bug 1663803 - Cherry-pick some upstream forms fixes to Firefox 81. r=…
121a6b3 
…bdahl, a=RyanVM

This is a cherry-pick of the following upstream commits:
mozilla/pdf.js#12344
mozilla/pdf.js#12345

Differential Revision: https://phabricator.services.mozilla.com/D89538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus left review comments

@timvandermeij timvandermeij timvandermeij left review comments

@brendandahl brendandahl brendandahl left review comments

Assignees
No one assigned
Labels
annotations form-acroform form-xfa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@calixteman @brendandahl @pdfjsbot @timvandermeij @Snuffleupagus