Commits on Sep 10, 2020

1. Let the loadingBar have the same width as the viewerContainer …

   For years the loadingBar and sidebarContainer has had a slightly annoying and unfortunate dependency, since the loadingBar width follows the main toolbar width[1].
   To prevent the loadingBar from obscuring part of the sidebarContainer, especially the buttons, the sidebarContainer is thus moved down when the loadingBar is visible. This has always annoyed me[2], since it means that the buttons in the sidebar may thus move vertically which seems bad from a UX perspective.
   
   Now that CSS variables are available in all supported browsers[3] however, fixing the loadingBar/sidebarContainer overlap issues are finally easy. The solution is simply to let the sidebarContainer, when visible, control the loadingBar left position (right in RTL locales) in the same way that the viewerContainer is handled. Hence the sidebarContainer can now have a *consistent* vertical postition, without the loadingBar overlapping it.
   
   ---
   [1] Obviously the right position (left in RTL locales) of the loadingBar is, potentially, reduced to account for a scrollbar.
   
   [2] I've tried to fix this a few times, but it always seemed like more trouble than it's worth.
   
   [3] https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties#Browser_compatibility

   

   Snuffleupagus committed Sep 10, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 17a5070
   • Browse repository at this point

   Copy the full SHA

   17a5070 View commit details

   Browse the repository at this point in the history