Implement resetting of created streams for annotations #12370
Conversation
|
/botio-linux preview |
timvandermeij
force-pushed
the
annotation-reset
branch
from
9150d58
to
4f959c4
Compare
|
/botio-linux preview |
|
Would it be possible to add a |
timvandermeij
force-pushed
the
annotation-reset
branch
from
4f959c4
to
48215be
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0070ce3ec6640ee/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/0070ce3ec6640ee/output.txt Total script time: 3.62 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/333dcc9f7b0b15b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/11b98d7ad921620/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/333dcc9f7b0b15b/output.txt Total script time: 27.72 mins
Image differences available at: http://54.67.70.0:8877/333dcc9f7b0b15b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/11b98d7ad921620/output.txt Total script time: 29.71 mins
Image differences available at: http://54.215.176.217:8877/11b98d7ad921620/reftest-analyzer.html#web=eq.log |
timvandermeij
force-pushed
the
annotation-reset
branch
from
48215be
to
3ecd984
Compare
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7d810f51b7a7c6f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/f9cb558961f375f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7d810f51b7a7c6f/output.txt Total script time: 25.68 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/f9cb558961f375f/output.txt Total script time: 27.77 mins
|
Fixes #12337.
Note that I tried to use a non-caching getter here, but I did not manage to get that to work. I found that if it were to work it would require more code changes and I found it not that great that we would not cache the appearance stream on the instance because it would lead to recalculation every time the annotation goes out of view. Therefore, after checking the alternatives, this solution seemed the simplest.