Refactor the container/viewer checks in the BaseViewer constructor #12388
Conversation
There was a problem hiding this comment.
The solution implemented here feels way too complex, considering that the purpose of these checks were simply to catch outright user error. Can this be implemented simpler, e.g. by just checking the tagName instead?
Furthermore, note that the existing checks are only relevant for one particular build and consequently we do not want to add this code in e.g. MOZCENTRAL builds.
jsg2021
changed the title
There was a problem hiding this comment.
Please improve the commit message, since it's currently a bit difficult to tell what the patch does without looking at the code and the linked issue.
For example, something like "Refactor the container/viewer checks in the BaseViewer constructor" might work. Furthermore, please also explain in the commit message why these changes are necessary; by mentioning the iframe use-case.
|
Sure thing! :) |
jsg2021
changed the title
The previous checks prevented specifying a container/viewer that was in another document/window. Fixes #12385
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9340338045b1e3a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9340338045b1e3a/output.txt Total script time: 3.53 mins Published |
|
Looks good to me. Thanks! |
Fixes #12385