Enable the ESLint no-var rule in the src/display/ folder
#12437
Conversation
Previously this rule has been enabled in the `web/` folder, and in select files in the `src/` sub-folders. Note that a number of the files in the `src/display/` folder were already enforcing the `no-var` rule, and thanks to Prettier the necessary re-writing will be (mostly) handled automatically. Please find additional details about the ESLint rule at https://eslint.org/docs/rules/no-var
This was done automatically, using `gulp lint --fix`.
While most of necessary changes were fixed automatically, see the previous patch, there's a number of cases that needed to be fixed manually.
Snuffleupagus
force-pushed
the
src-display-no-var
branch
from
d72badb
to
52f6016
Compare
|
/botio lint |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6f8f05240379b94/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/689c7ff42bb78ea/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/689c7ff42bb78ea/output.txt Total script time: 2.25 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6f8f05240379b94/output.txt Total script time: 2.88 mins
|
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/7a238723cb1369b/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6d1c66c1fd37f61/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/6d1c66c1fd37f61/output.txt Total script time: 27.54 mins
Image differences available at: http://54.67.70.0:8877/6d1c66c1fd37f61/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/7a238723cb1369b/output.txt Total script time: 32.20 mins
Image differences available at: http://54.215.176.217:8877/7a238723cb1369b/reftest-analyzer.html#web=eq.log |
|
Thank you for doing this! |
Previously this rule has been enabled in the
web/folder, and in select files in thesrc/sub-folders.Note that a number of the files in the
src/display/folder were already enforcing theno-varrule, and thanks to Prettier the necessary re-writing will be (mostly) handled automatically.Please find additional details about the ESLint rule at https://eslint.org/docs/rules/no-var